[emval] Simplify dynamic invoker creation. NFC #24619
Merged
+39
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
force-pushed
the
opt-create-invoker
branch
2 times, most recently
from
049e9cc to
42d9dac
Compare
|
I fixed CI, this should be ready for review (I'll just need to rebaseline again before merging). |
sbc100
reviewed
Jul 9, 2025
| functionBody += | ||
| ' return emval_returnValue(toReturnWire, destructorsRef, rv);\n'; | ||
| captures['toReturnWire'] = toReturnWire; | ||
| captures['emval_returnValue'] = emval_returnValue; |
There was a problem hiding this comment.
Would it be slightly more compact to just list all the captures in the object literal above? i.e. is there any harm in capturing stuff that isn't used?
There was a problem hiding this comment.
For now, just tiny memory overhead I guess, but when we implement AOT as shown in #24540, this will also result in larger method caller functions in the static JS.
I'd rather keep it.
sbc100
approved these changes
Jul 9, 2025
RReverser
force-pushed
the
opt-create-invoker
branch
from
42d9dac to
fd34acc
Compare
|
Looks like AOT mode is broken. |
Yeah which is weird, because I already fixed it - it was fine in 049e9cc. I think I force-pushed something wrong from the other laptop. Will fix. |
RReverser
force-pushed
the
opt-create-invoker
branch
from
fd34acc to
12789d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.